Change __builtin_types to __builtin_types_compatible_p#1647
Merged
semmle-qlci merged 4 commits intogithub:masterfrom Jul 30, 2019
Merged
Change __builtin_types to __builtin_types_compatible_p#1647semmle-qlci merged 4 commits intogithub:masterfrom
__builtin_types to __builtin_types_compatible_p#1647semmle-qlci merged 4 commits intogithub:masterfrom
Conversation
| */ | ||
| class BuiltInOperationBuiltInTypes extends BuiltInOperation, @typescompexpr { | ||
| override string toString() { result = "__builtin_types" } | ||
| class BuiltInOperationBuiltInTypesCompatibleP extends BuiltInOperation, @typescompexpr { |
Contributor
There was a problem hiding this comment.
I'm probably being overly paranoid here, but since the name BuiltInOperationBuiltInTypes was part of the supported API, we shouldn't make that name go away without deprecating it for a few releases first. I recommend adding an alias from the old name to the new name, something like:
/**
* DEPRECATED: Use `BuiltInOperationBuiltInTypesCompatibleP instead.instead.
*/
deprecated
class BuiltInOperationBuiltInTypes = BuiltInOperationBuiltInTypesCompatibleP;this.getChild(0) }
Contributor
Author
There was a problem hiding this comment.
Good idea, I'll add that.
…nBuiltInTypesCompatibleP, for backward compatibility.
Co-Authored-By: Dave Bartolomeo <42150477+dave-bartolomeo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noting that (1)
__builtin_typeshas no known definition or uses and (2) the QL library does not handle__builtin_types_compatible_p, I propose to rename the former to the latter.